-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move changelog from dialog to separate view #7312
base: main
Are you sure you want to change the base?
Move changelog from dialog to separate view #7312
Conversation
218e9f4
to
db2a347
Compare
8c83dfb
to
595c730
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 5 of 5 files at r3, 13 of 13 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 11 of 11 files at r7, 3 of 3 files at r8, 12 of 12 files at r9, 1 of 1 files at r10, 2 of 2 files at r11, 6 of 6 files at r12, 2 of 2 files at r13, 1 of 1 files at r14, 5 of 5 files at r15, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @olmoh)
desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/ChangelogView.tsx
line 69 at r7 (raw file):
</Container> <Container size="3" $flexDirection="column"> {!changelog.length ? (
This should be the inverse, right? 😊
changelog.length ? <render-changes> : <render-placeholder>
Code quote:
!changelog.length ?
595c730
to
ad65eb5
Compare
This change is